Merge stable v1.0.x into main #1451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix initialize description in memory pool ops
add ctl_stats to remaining providers
[CMake] Update deprecated msg for hwloc option
We cache only 'vcpkg/packages' dir as it's all that's needed. The speed up is from ~10 mins of deps downloading and building to a few seconds. Binaries, though, may be incompatible between different machines and Windows, so cache per w'flow and machine. Co-authored-by: Rafał Rudnicki <[email protected]>
[CI] Add vcpkg caching in Win workflows
There was a problem hiding this comment.
Pull Request Overview
This PR merges the stable v1.0.x branch into main, updating UMF to version 1.0.0. The changes include adding memory statistics tracking functionality to all memory providers, improving CI workflow efficiency with vcpkg caching, and updating version-related documentation.
- Implements ctl_stats functionality across all memory providers for allocation tracking
- Adds comprehensive test coverage for statistics tracking in all provider types
- Optimizes CI workflows by implementing vcpkg package caching on Windows
- Updates version references from v1.0.0-rc2 to v1.0.0 and deprecation notices
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/providers/provider_level_zero.cpp | Adds ctl_stats test for Level Zero provider |
| test/providers/provider_cuda.cpp | Adds ctl_stats test for CUDA provider |
| test/provider_os_memory.cpp | Adds ctl_stats test for OS memory provider |
| test/provider_fixed_memory.cpp | Adds ctl_stats test for fixed memory provider |
| test/provider_file_memory.cpp | Adds ctl_stats test for file memory provider |
| test/provider_devdax_memory.cpp | Adds ctl_stats test for devdax memory provider |
| src/provider/provider_level_zero.c | Implements statistics tracking with helper functions |
| src/provider/provider_file_memory.c | Adds ctl support and statistics tracking |
| src/provider/provider_devdax_memory.c | Adds ctl support and statistics tracking |
| src/provider/provider_cuda.c | Adds ctl support and statistics tracking |
| include/umf/memory_pool_ops.h | Updates documentation comment |
| ChangeLog | Updates version from 1.0.0-rc2 to 1.0.0 |
| CMakeLists.txt | Updates deprecation notice version |
| .github/workflows/*.yml | Adds vcpkg caching support for Windows builds |
Comments suppressed due to low confidence (4)
src/provider/provider_level_zero.c:379
- [nitpick] The function name 'ze_memory_provider_alloc_helper' could be more descriptive. Consider renaming to 'ze_memory_provider_alloc_with_stats' or 'ze_memory_provider_alloc_internal' to better convey its purpose.
static umf_result_t ze_memory_provider_alloc_helper(void *provider, size_t size,
src/provider/provider_level_zero.c:459
- [nitpick] The function name 'ze_memory_provider_free_helper' could be more descriptive. Consider renaming to 'ze_memory_provider_free_with_stats' or 'ze_memory_provider_free_internal' to better convey its purpose.
static umf_result_t ze_memory_provider_free_helper(void *provider, void *ptr,
src/provider/provider_level_zero.c:381
- The parameter 'update_stats' uses int type for a boolean flag. Consider using bool type instead for better code clarity.
int update_stats,
src/provider/provider_level_zero.c:461
- The parameter 'update_stats' uses int type for a boolean flag. Consider using bool type instead for better code clarity.
int update_stats) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.